Skip to content
This repository was archived by the owner on Jul 16, 2026. It is now read-only.

Implement support for new Edge based on Chromium (rename the current Edge to EdgeLagacy) - #166

Open
danieljtag wants to merge 30 commits into
SAP-archive:masterfrom
danieljtag:master
Open

Implement support for new Edge based on Chromium (rename the current Edge to EdgeLagacy)#166
danieljtag wants to merge 30 commits into
SAP-archive:masterfrom
danieljtag:master

Conversation

@danieljtag

@danieljtag danieljtag commented Feb 11, 2020

Copy link
Copy Markdown
Contributor

Implement support for new Edge browser based on Chromium (rename the current Edge to EdgeLagacy)
Implement get Edge (Chromium) WebDriver automatically from url

Created this new pull-request that will replace pull-requests #163 & #164
(see also comments on pull-request #163)

simplesoftlabs
simplesoftlabs reviewed Feb 12, 2020
View reviewed changes
Comment thread conf/profile.conf.js Outdated
Comment thread docs/config/drivers.md
This was referenced Feb 14, 2020
Closed
Closed
@danieljtag

danieljtag commented Feb 17, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

After verification, looks like there is no 'redirect url' (as for firefox case) or LATEST_RELEASE_X url (as for chrome case) to get the latest webdriver version from Microsoft for Edge chromium.

How do you suggest to identify the latest WebDriver version from Microsoft web site? For now in this pull request, Edge webdriver download and file re-name is working ok, but the version (major + minor) must be in profile.conf.js

@danieljtag

danieljtag commented Mar 6, 2020

Copy link
Copy Markdown
Contributor Author

Let me know if any other comments, thank you

@danieljtag

danieljtag commented Mar 6, 2020

Copy link
Copy Markdown
Contributor Author

Fyi, for any testing from this fork (before a merge to master) the profile.conf.js file must be maintained with:
latestCompleteVersionFileUrl: 'https://raw.githubusercontent.com/danieljtag/ui5-uiveri5/master/driverVersions.json'

@CLAassistant

CLAassistant commented Mar 16, 2020 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

tsaleksandrova
tsaleksandrova reviewed Mar 16, 2020
View reviewed changes
Comment thread src/connection/directConnectionProvider.js Outdated
Comment thread src/connection/latestDriverVersionResolver.js Outdated
Comment thread src/connection/latestDriverVersionResolver.js Outdated
Comment thread src/connection/latestDriverVersionResolver.js
Comment thread src/connection/latestDriverVersionResolver.js
@danieljtag

danieljtag commented May 7, 2020

Copy link
Copy Markdown
Contributor Author

any update about the merge ?

@danieljtag

danieljtag commented Aug 14, 2020

Copy link
Copy Markdown
Contributor Author

@maximnaidenov could you review this pull request ? thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@simplesoftlabs simplesoftlabs simplesoftlabs left review comments
@tsaleksandrova tsaleksandrova tsaleksandrova left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@danieljtag @CLAassistant @simplesoftlabs @tsaleksandrova @danjtag789